[CodeStyle][Ruff][BUAA][D-[7-13]] Fix ruff RUF015 diagnostic for 6 files in python/paddle/
#67359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MufanColin
requested review from
SigureMo,
Aurelius84 and
gouzil
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Aug 13, 2024
| for param_grad in params_grads | ||
| if param_grad[0].name == self.table_name | ||
| ), | ||
| None, # Default value if no matching param_grad is found |
There was a problem hiding this comment.
为什么要修改原来的逻辑？原来如果找不到会直接报错，而现在会隐藏
There was a problem hiding this comment.
那我是直接把 None 去掉吗？
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Devs
Description
python/paddle/distributed/passes/auto_parallel_data_parallel_optimization.pypython/paddle/distributed/transpiler/distribute_transpiler.pypython/paddle/pir/math_op_patch.pypython/paddle/static/amp/function_overload.pysetup.pytest/sot/test_model_switch_training.pytest/xpu/test_tril_triu_op_xpu.pyRelated Links
@gouzil