【BUAA】【Infer Symbolic Shape No.152,153】Add max_pool2d_with_index and max_pool3d_with_index #67390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
coverage_exit: 9 max_pool2d_with_index和 max_pool3d_with_index均无相应OpTest文件 |
Comment on lines
1325
to
887
| const auto &x = x_shape[i + 2]; | ||
| if (x.isa<int64_t>()) { | ||
| kernel_size_[i] = static_cast<int64_t>(x.Get<std::int64_t>()); | ||
| } | ||
| } |
There was a problem hiding this comment.
这里应该不需要特判x是否为int64，kernel_size_直接变成DimExpr参与符号计算即可
Comment on lines
1348
to
1357
| int64_t x = static_cast<int64_t>(x_dim.Get<std::int64_t>()); | ||
| if (x < 0) { | ||
| out_shape.push_back(x_shape[i + 2]); | ||
| } else { | ||
| PADDLE_ENFORCE_NE( | ||
| strides[i], | ||
| 0, | ||
| phi::errors::InvalidArgument( | ||
| "The stride of MaxPool shall not be 0, but received %d.", | ||
| strides[i])); |
There was a problem hiding this comment.
直接使用符号计算，这里x<0是infer meta无法处理动态shape做的特判
Comment on lines
+1386
to
+972
| bool MaxPool3dWithIndexOpInferSymbolicShape( | ||
| pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) { |
There was a problem hiding this comment.
两个函数有很多相同逻辑，建议抽象点共同操作
…pe/.ipynb_checkpoints directory
luotao1
approved these changes
Aug 16, 2024
| std::vector<int> strides = | ||
| paddle::dialect::details::GetVectorAttr<int>(op, "strides"); | ||
| std::vector<int> kernel_sizes_ = | ||
| paddle::dialect::details::GetVectorAttr<int>(op, "kernel_sizes"); |
|
typo修复PR：#67548 |
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
添加 max_pool2d_with_index和 max_pool3d_with_index 算子符号推导接口实现。