【BUAA】【Infer Symbolic Shape】add shardindex #67407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
|
shardindex存在对应单测，check_pir默认关闭，请求豁免coverage |
Comment on lines
1770
to
1779
| int64_t last_dim = | ||
| static_cast<int>(in_shape[in_shape.size() - 1].Get<std::int64_t>()); | ||
| if (last_dim > 0) { | ||
| PADDLE_ENFORCE_EQ(last_dim, | ||
| 1, | ||
| common::errors::InvalidArgument( | ||
| "The last dimension of Input(X) should be 1, " | ||
| "but the value given is %d.", | ||
| last_dim)); | ||
| } |
There was a problem hiding this comment.
last_dim不一定就是int64_t，这里直接加约束就好
Hongqing-work
previously approved these changes
Aug 15, 2024
|
冲突了 |
|
麻烦补充描述下单测情况，并在表格中勾选 |
shardindex存在对应单测，check_pir默认关闭，请求豁免coverage |
luotao1
approved these changes
Aug 16, 2024
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
添加 ShardIndex 算子符号推导接口实现。