Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prim][PIR] Add the dynamic shape test case for scale_grad, square_grad, transpose_grad and swiglu_grad #67590

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

zeroRains
Copy link
Contributor

@zeroRains zeroRains commented Aug 20, 2024

PR Category

Operator Mechanism

PR Types

New features

Description

为scale_grad, square_grad, transpose_grad, swiglu_grad添加动态shape单测

本次PR修改了backwar_util.py中列表的顺序(字母序排列),并且将原本冗余堆积在一起的test_prim_sub_graph_backward_dynamic_shape.py文件拆分成了5个文件,test_prim_sub_graph_backward_dynamic_shape.py仍然保留基类单测,其他的文件格式如下test_prim_sub_graph_{算子首字母集合}_backward_dynamic_shape.py,比如test_prim_sub_graph_abcde_backward_dynamic_shape.py则表示了算子首字母在集合{a,b,c,d,e}中的算子,并且每个文件内部也是按照字母序进行排序,希望后续开发者也能遵守规则,在适当的文件中按照字母序添加对应的算子,以此减少每次PR的冲突。

Copy link

paddle-bot bot commented Aug 20, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 20, 2024
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backward_utils 里的列表按照字母序排一下吧,也许可以减少冲突

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoguoguo626807 xiaoguoguo626807 merged commit a38d03b into PaddlePaddle:develop Aug 27, 2024
28 of 29 checks passed
@zeroRains zeroRains deleted the test branch August 27, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants