【Infer Symbolic Shape No.232】【BUAA】Add svd, changed 3 files #67664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
35 tasks
|
Sorry to inform you that 40cd98a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
gongshaotian
reviewed
Sep 4, 2024
| const symbol::DimExpr m = x_shapes[x_rank - 2]; | ||
| const symbol::DimExpr n = x_shapes[x_rank - 1]; | ||
| const symbol::DimExpr k = | ||
| std::min(m.Get<std::int64_t>(), n.Get<std::int64_t>()); |
There was a problem hiding this comment.
这里应该用symbol::DimExprBuilder builder; builder.min()
This was referenced Sep 5, 2024
gongshaotian
reviewed
Sep 9, 2024
| const symbol::DimExpr n = x_shapes[x_rank - 1]; | ||
| symbol::DimExprBuilder builder; | ||
| const symbol::DimExpr k = | ||
| builder.Min(m.Get<std::int64_t>(), n.Get<std::int64_t>()); |
There was a problem hiding this comment.
builder.min() 不需要使用.Get() 了
luotao1
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
加入了svd
单测位于
test\legacy_test\test_svd_op.pyself.check_output(no_check_set=['U', 'VH'], check_pir=True)，其中默认check_symbol_infer=True,