【Infer Symbolic Shape No.125】【BUAA】Add BroadcastTensor, changed 3 files #67744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
This was referenced Sep 5, 2024
gongshaotian
reviewed
Sep 8, 2024
Comment on lines
666
to
679
| std::vector<symbol::DimExpr> out_shape; | ||
| for (size_t i = 0; i < target_rank; i++) { | ||
| out_shape.push_back(symbol::DimExpr{1}); | ||
| } | ||
|
|
||
| symbol::DimExprBuilder builder; | ||
| for (size_t i = 0; i < input_shape_or_data_list.size(); i++) { | ||
| size_t tmp_bound = input_shape_or_data_list[i].shape().size(); | ||
| for (size_t j = 0; j < tmp_bound; j++) { | ||
| out_shape[target_rank - j - 1] = builder.Broadcast( | ||
| input_shape_or_data_list[i].shape()[tmp_bound - j - 1], | ||
| out_shape[target_rank - j - 1]); | ||
| } | ||
| } |
There was a problem hiding this comment.
1.这里不需要初始化为1了
2.Broadcast可以嵌套，参考这个伪代码写吧
3. 再内层for循环里做Broadcast操作时添加一个broadcast约束
AddBrpadCast(shape_or_data_list[i].shape()[0], shape_or_data_list[i].shape()[j])
There was a problem hiding this comment.
需要从最后一个维度往前做broadcast比对，每个tensor长度不一样，如果长度短，前面缺的用1补全，那么最内层for循环每次都需要判断shape_or_data_list[j]的长度，这样可以吗？
gongshaotian
reviewed
Sep 8, 2024
| } | ||
|
|
||
| symbol::TensorListShapeOrDataDimExprs out_shapes; | ||
| for (size_t i = 0; i < target_rank; i++) { |
There was a problem hiding this comment.
i < input_shape_or_data_list.size()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
加入broadcast_tensors:
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.h
paddle/phi/ops/yaml/ops.yaml