Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【complex op No.50】tan_coo/tan_csr(sparse) #67848

Closed
wants to merge 2 commits into from
Closed

【complex op No.50】tan_coo/tan_csr(sparse) #67848

wants to merge 2 commits into from

Conversation

Aoraki-Dream
Copy link
Contributor

PR Category

Operator Mechanism

PR Types

New features

Description

add complex support for tan_coo/tan_csr in sparse

Copy link

paddle-bot bot commented Aug 29, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 29, 2024
@Aoraki-Dream Aoraki-Dream marked this pull request as draft August 30, 2024 01:16
@Aoraki-Dream
Copy link
Contributor Author

@luotao1 @zhiminzhang0830 请老师检查一下

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 30, 2024
@Aoraki-Dream Aoraki-Dream marked this pull request as ready for review August 30, 2024 06:59
@@ -76,6 +75,7 @@ PD_REGISTER_SPARSE_UNARY_CPU_GRAD_KERNEL(expm1, Expm1)
PD_REGISTER_SPARSE_UNARY_CPU_GRAD_KERNEL(relu6, Relu6)
PD_REGISTER_SPARSE_UNARY_CPU_GRAD_KERNEL(leaky_relu, LeakyRelu)

PD_REGISTER_SPARSE_UNARY_CPU_GRAD_KERNEL_WITH_COMPLEX(tan, Tan)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpu处的反向也需要进行注册一下

self.compare_with_dense(paddle.tan, paddle.sparse.tan, 'float32')
self.compare_with_dense(paddle.tan, paddle.sparse.tan, 'float64')
self.compare_with_dense(paddle.tan, paddle.sparse.tan, 'complex64')
self.compare_with_dense(paddle.tan, paddle.sparse.tan, 'complex128')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

静态图的TestSparseUnaryStatic也需要添加上test

@Aoraki-Dream
Copy link
Contributor Author

由于分支提交历史混乱,修改之后重新提交pr,#67885

Copy link

paddle-ci-bot bot commented Sep 7, 2024

Sorry to inform you that fa099e2's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1 luotao1 closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants