【Infer Symbolic Shape No.170】【BUAA】 Add read_file op #67889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gongshaotian
reviewed
Sep 2, 2024
| bool ReadFileOpInferSymbolicShape( | ||
| pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) { | ||
| std::vector<symbol::DimExpr> output_shape = {symbol::DimExpr(1), | ||
| symbol::DimExpr(-1)}; |
There was a problem hiding this comment.
-1是meta中表示动态维度的，这里应该使用新符号
33 tasks
|
PR-CI-Coverage 中没过的测试好像不是我改的内容。 |
tlxd
reviewed
Sep 9, 2024
| std::vector<symbol::DimExpr> shape; | ||
| shape.push_back(unique_dim_sym); | ||
| return shape; | ||
| }(); |
There was a problem hiding this comment.
- Meta 函数里的维度是 {1, -1} ，rank 是 2，这里应该改成 {symbol::DimExpr(1), 新符号} ，而不是整体使用 {新符号}
- push_back() 可以替换成 empalce_back()
- 发生了冲突，也顺便解决一下
|
麻烦补充一下单测状态 |
gongshaotian
reviewed
Sep 9, 2024
| @@ -29,6 +29,7 @@ OP_DECLARE_INFER_SYMBOLIC_SHAPE(FullIntArray) | |||
| OP_DECLARE_INFER_SYMBOLIC_SHAPE(Gaussian) | |||
| OP_DECLARE_INFER_SYMBOLIC_SHAPE(Randint) | |||
| OP_DECLARE_INFER_SYMBOLIC_SHAPE(Randperm) | |||
| OP_DECLARE_INFER_SYMBOLIC_SHAPE(ReadFile) | |||
| OP_DECLARE_INFER_SYMBOLIC_SHAPE(Seed) | |||
| // OP_DECLARE_INFER_SYMBOLIC_SHAPE(ReadFile) | |||
gongshaotian
approved these changes
Sep 9, 2024
|
请问是否需要重新 rerun。 |
luotao1
approved these changes
Sep 19, 2024
|
650 - test_write_python_container (Failed) |
是随机挂问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
添加 read_file 算子符号推导接口。