[Paddle Tensorrt] add pd_op.greater_than, pd_op.less_than marker and converter #68686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Hanyonggong
changed the title
Hanyonggong
changed the title
Hanyonggong
changed the title
lizexu123
reviewed
Oct 14, 2024
| layer_output = add_elementwise_layer( | ||
| network, paddle_op, inputs, trt.ElementWiseOperation.GREATER | ||
| ) | ||
| return trt_cast(network, layer_output, trt.float32) |
lizexu123
reviewed
Oct 14, 2024
| layer_output = add_elementwise_layer( | ||
| network, paddle_op, inputs, trt.ElementWiseOperation.LESS | ||
| ) | ||
| return trt_cast(network, layer_output, trt.float32) |
|
|
||
|
|
||
| @converter_registry.register("pd_op.greater_than", trt_version="8.x") | ||
| def greater_than_converter(network, paddle_op, inputs): |
There was a problem hiding this comment.
建议Binray的Converter可以合并
XieYunshen
previously approved these changes
Oct 18, 2024
| def setUp(self): | ||
| self.python_api = paddle.greater_than | ||
| self.api_args = { | ||
| "x": np.random.randn(3).astype(np.float32), |
There was a problem hiding this comment.
整体没啥问题，但是单测是否覆盖更多的类型，例如INT、float16等类型会更好。
lizexu123
previously approved these changes
Oct 22, 2024
XieYunshen
previously approved these changes
Oct 23, 2024
yuanlehome
reviewed
Oct 23, 2024
Comment on lines
27
to
34
| if paddle_op.name() == "pd_op.greater_than": | ||
| layer_output = add_elementwise_layer( | ||
| network, paddle_op, inputs, trt.ElementWiseOperation.GREATER | ||
| ) | ||
| else: | ||
| layer_output = add_elementwise_layer( | ||
| network, paddle_op, inputs, trt.ElementWiseOperation.LESS | ||
| ) |
There was a problem hiding this comment.
这里分支处理并不严谨，建议改成这样
Suggested change
| if paddle_op.name() == "pd_op.greater_than": | |
| layer_output = add_elementwise_layer( | |
| network, paddle_op, inputs, trt.ElementWiseOperation.GREATER | |
| ) | |
| else: | |
| layer_output = add_elementwise_layer( | |
| network, paddle_op, inputs, trt.ElementWiseOperation.LESS | |
| ) | |
| if paddle_op.name() == "pd_op.greater_than": | |
| layer_output = add_elementwise_layer( | |
| network, paddle_op, inputs, trt.ElementWiseOperation.GREATER | |
| ) | |
| elif paddle_op.name() == "pd_op.less_than":: | |
| layer_output = add_elementwise_layer( | |
| network, paddle_op, inputs, trt.ElementWiseOperation.LESS | |
| ) | |
| else: | |
| throw xxx |
yuanlehome
reviewed
Oct 23, 2024
| return false; | ||
| } | ||
| #if IS_TRT_VERSION_LT(8400) | ||
| VLOG(3) << "LessThanOp is not supported when TensorRT < 8.4"; |
There was a problem hiding this comment.
Suggested change
| VLOG(3) << "LessThanOp is not supported when TensorRT < 8.4"; | |
| VLOG(3) << "pd_op.less_than is not supported when TensorRT < 8.4"; |
yuanlehome
reviewed
Oct 23, 2024
| auto x_dtype = pir::GetDataTypeFromValue(x); | ||
| auto y_dtype = pir::GetDataTypeFromValue(y); | ||
| if (x_dtype.isa<pir::BoolType>() || y_dtype.isa<pir::BoolType>()) { | ||
| VLOG(3) << "Greater_than op do not support bool datatype"; |
There was a problem hiding this comment.
Suggested change
| VLOG(3) << "Greater_than op do not support bool datatype"; | |
| VLOG(3) << "pd_op.greater_than op do not support bool datatype"; |
Hanyonggong
dismissed stale reviews from XieYunshen and lizexu123
via
62f57eb
yuanlehome
approved these changes
Oct 24, 2024
XieYunshen
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
New features
Description
card-71500
添加greater_than op 和 less_than op的marker、converter和单测