[CINN] Delele some redundant code #69031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lshpku
approved these changes
Oct 30, 2024
Comment on lines
26
to
30
|
|
||
| void Module::Builder::AddFunction(ir::LoweredFunc func) { | ||
| optim::Simplify(&(func->body)); | ||
| optim::SimplifyForLoops(&(func->body)); | ||
| optim::SimplifyBlocks(&(func->body)); | ||
| func->body = optim::Optimize(func->body, module_->target); | ||
| module_->functions.push_back(func); | ||
| } | ||
|
|
There was a problem hiding this comment.
这里为啥删除啊，删了之后和AddFunctionWithoutOptim一样了，相当于是把Add的功能清晰化了？但是外面又没有补充优化的函数
There was a problem hiding this comment.
我想是不是把AddFunctionWithoutOptim也删了，要做什么优化由持有Function的人来做，不是由Module来做
There was a problem hiding this comment.
是的，感觉可以下个PR改一下，Module Module::Builder::Build()那里的优化也最好可以提出来
phlrain
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Devs
Description
Pcard-67164
清理CINN中冗余执行流程