Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOT] Prohibit treating instances of BooleanEnvironmentVariable directly as boolean values #69412

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Nov 14, 2024

PR Category

Execute Infrastructure

PR Types

Performance

Description

禁止将 BooleanEnvironmentVariable 的实例直接当成bool值防止出现意外情况

Copy link

paddle-bot bot commented Nov 14, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 14, 2024
@SigureMo SigureMo changed the title Prohibit treating instances of BooleanEnvironmentVariable directly as boolean values [SOT][3.13] Prohibit treating instances of BooleanEnvironmentVariable directly as boolean values Nov 14, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo changed the title [SOT][3.13] Prohibit treating instances of BooleanEnvironmentVariable directly as boolean values [SOT][3.13] Prohibit treating instances of BooleanEnvironmentVariable directly as boolean values Nov 14, 2024
@SigureMo SigureMo merged commit 267a203 into PaddlePaddle:develop Nov 15, 2024
27 of 28 checks passed
@SigureMo SigureMo changed the title [SOT][3.13] Prohibit treating instances of BooleanEnvironmentVariable directly as boolean values [SOT] Prohibit treating instances of BooleanEnvironmentVariable directly as boolean values Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants