Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][C-[10-15]] Fix typo(CACH(4), catched(2), cuase(2), channles(1), channnel(2), cahr(1))。 #69552

Closed
wants to merge 6 commits into from

Conversation

little1d
Copy link
Contributor

@little1d little1d commented Nov 20, 2024

PR Category

User Experience

PR Types

Devs

Description

fit:

  • CACH
  • catched
  • cuase
  • channles
  • channnel
  • cahr

Copy link

paddle-bot bot commented Nov 20, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 20, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@little1d little1d closed this Nov 20, 2024
@little1d little1d changed the title [CodeStyle][Typos][A-[11-19]] Fix typo(CACH(4), catched(2), cuase(2), channles(1), channnel(2), cahr(1)) [CodeStyle][Typos][C-[10-15]] Fix typo(CACH(4), catched(2), cuase(2), channles(1), channnel(2), cahr(1)) Nov 20, 2024
@little1d little1d reopened this Nov 20, 2024
@MrXnneHang
Copy link
Contributor

MrXnneHang commented Nov 20, 2024

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 20, 2024
@little1d
Copy link
Contributor Author

那我现在要重新修改提一个 PR 吗(新手保护 @MrXnneHang

paddle/fluid/framework/data_feed.cc Outdated Show resolved Hide resolved
paddle/fluid/framework/data_feed.cc Outdated Show resolved Hide resolved
@MrXnneHang
Copy link
Contributor

MrXnneHang commented Nov 20, 2024

@little1d
直接commit push到你 PR 的分支即可。另外你似乎得去那个机器人那边签署一下 CLA

@little1d
Copy link
Contributor Author

当时一直commit 不上去,我参考了 #69483 的Git常见问题部分,那里推荐先checkout到本次修改的任务标识分支中。
image
后来问题是因为git commit是需要添加参数-n

@little1d
Copy link
Contributor Author

@little1d 直接commit push到你 PR 的分支即可。另外你似乎得去那个机器人那边签署一下 CLA

好的,谢谢老师

@little1d little1d changed the title [CodeStyle][Typos][C-[10-15]] Fix typo(CACH(4), catched(2), cuase(2), channles(1), channnel(2), cahr(1)) [CodeStyle][Typos][C-[10-15]] Fix typo(CACH(4), catched(2), cuase(2), channles(1), channnel(2), cahr(1))。 Nov 20, 2024
@little1d little1d closed this Nov 20, 2024
@little1d little1d reopened this Nov 20, 2024
@MrXnneHang
Copy link
Contributor

当时一直commit 不上去,我参考了 #69483 的Git常见问题部分,那里推荐先checkout到本次修改的任务标识分支中。 image 后来问题是因为git commit是需要添加参数-n

我还从来没有用过-n,但似乎它会跳过一些git hooks?下次最好不要这么做,先把你commit -m提交不上去报的错误丢到FAQ里给我看看。
我也是同学(>_<)

@little1d
Copy link
Contributor Author

好的同学,是因为报错里的内容没有我修改的内容,在社区大群里之前有同学遇到过这个问题,导师的回答是加一个-n参数,确保自己修改的文件通过 pre-commit 就可以了。但确实,是我的遗漏,我没仔细检查 pr,导致 pre-commit没过,不应该加这个参数。抱歉

@little1d
Copy link
Contributor Author

@MrXnneHang 同学,可以再问您一个问题吗,我签署了 CLA,但是第二个机器人为啥还在pending
image

@MrXnneHang
Copy link
Contributor

image

@little1d
Copy link
Contributor Author

image

recheck 好多次了

@luotao1
Copy link
Contributor

luotao1 commented Nov 20, 2024

第二个机器人为啥还在pending

因为第一次提交PR,需要人工后台approve,才能跑CI流程。请耐心等待下,稍后可以看到其他CI会跑了。

@little1d
Copy link
Contributor Author

第二个机器人为啥还在pending

因为第一次提交PR,需要人工后台approve,才能跑CI流程。请耐心等待下,稍后可以看到其他CI会跑了。

好的,谢谢骆姐😘😘

@little1d
Copy link
Contributor Author

CI,PR,Git相关的下次发到FAQ里。这里留着review就可以了。 image 这里显示你已经签署,可以尝试推送代码来触发CI,然后再把代码恢复回去再推送一次。

嗯嗯嗯,好的,第一次 pr,学到了。
ps: 您的解决办法也试过了,不起作用,应该是骆姐描述的问题

@little1d little1d closed this Nov 20, 2024
@little1d little1d reopened this Nov 20, 2024
@little1d little1d closed this Nov 20, 2024
@little1d little1d deleted the C_words branch November 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants