Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][A-[1-10]] Fix typos (Acceses, accessable, accesss, accoding, accurary, Accuarcy, actived, acitve, actualy, Actural, actural) #69627

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

fxy1699
Copy link
Contributor

@fxy1699 fxy1699 commented Nov 22, 2024

PR Category

User Experience

PR Types

Devs

Description

Fix:

  • Acceses
  • accessable
  • accesss
  • accoding
  • accurary
  • actived
  • acitve
  • actualy
  • Actural/actural
  • Accuarcy

Copy link

paddle-bot bot commented Nov 22, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 22, 2024
@fxy1699
Copy link
Contributor Author

fxy1699 commented Nov 22, 2024

#69575 查了一下没有找到好的解决办法只能重开了

@MrXnneHang
Copy link
Contributor

MrXnneHang commented Nov 22, 2024

Accuarcy 是不是漏了
你的_typos.toml漏删了一个

@fxy1699
Copy link
Contributor Author

fxy1699 commented Nov 22, 2024

Accuarcy 是不是漏了 你的_typos.toml漏删了一个

这个是没有修改的,涉及到API变动,删了typos不是会报错吗

@MrXnneHang
Copy link
Contributor

MrXnneHang commented Nov 22, 2024

按照下面那个方法改

@SigureMo
Copy link
Member

你在没有修改的那一行后面加一个注释#Undo : Accuarcy

#69558 (comment)

这种情况不要加注释,直接移到上面

Accuarcy 涉及API名称变动

不过 AccuarcyCheckPass 等均非公开 API,全部应该修改

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 25, 2024
@fxy1699 fxy1699 requested a review from SigureMo as a code owner November 26, 2024 05:44
@fxy1699
Copy link
Contributor Author

fxy1699 commented Nov 26, 2024

按照下面那个方法改

已修改

@@ -29,7 +29,6 @@ accessable = 'accessable'
accesss = 'accesss'
accoding = 'accoding'
accurary = 'accurary'
Accuarcy = 'Accuarcy'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 PR 改的不止这一个吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉merge的时候这部忘记保存了,已修改

@SigureMo SigureMo changed the title [CodeStyle][Typos][A-[1-10]] Fix typo(Acceses、accessable、accesss、accoding、accurary、Accuarcy、actived、acitve、actualy、Actural、actural) [CodeStyle][Typos][A-[1-10]] Fix typos (Acceses, accessable, accesss, accoding, accurary, Accuarcy, actived, acitve, actualy, Actural, actural) Nov 26, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit a07119d into PaddlePaddle:develop Nov 26, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants