【BUPT】【Paddle TensorRT No.18】Add pd_op.conv3d and pd_op.conv3d_transpose converter #69757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lizexu123
reviewed
Nov 27, 2024
| op->attribute<pir::BoolAttribute>(kCanRunTrtAttr).data()) { | ||
| return false; | ||
| } | ||
|
|
| @@ -374,6 +375,42 @@ class DepthwiseConv2dTransposeOpPattern | |||
| } | |||
| }; | |||
|
|
|||
| class Conv3dTransposeOpPattern | |||
| : public pir::OpRewritePattern<paddle::dialect::Conv3dTransposeOp> { | |||
There was a problem hiding this comment.
你写的到底是conv3d还是conv3d_transpose
lizexu123
reviewed
Nov 29, 2024
| if (op->HasAttribute("padding_algorithm")) { | ||
| auto padding_algorithm = | ||
| op->attribute<pir::StrAttribute>("padding_algorithm").AsString(); | ||
| if (padding_algorithm == "SAME") { |
There was a problem hiding this comment.
这个检查不对，conv3d_transpose且是same且不是动态shape才不让进trt
| VLOG(3) << "In conv3d, paddings size must be less than or equal to 3"; | ||
| return false; | ||
| } | ||
|
|
| dilation = paddle_op.attrs().get("dilations", [1, 1, 1]) | ||
| groups = paddle_op.attrs().get("groups", 1) | ||
|
|
||
| if has_dynamic_shape(input_shape): |
|
|
||
| output_padding = paddle_op.attrs().get("output_padding", [0, 0, 0]) | ||
| padding_algorithm = paddle_op.attrs().get("padding_algorithm", "EXPLICIT") | ||
| if padding_algorithm == "VALID": |
| nv_dilations = trt.Dims3(dilation[0], dilation[1], dilation[2]) | ||
| nv_strides = trt.Dims3(stride[0], stride[1], stride[2]) | ||
|
|
||
| pre_paddings = [0, 0, 0] |
There was a problem hiding this comment.
pre_paddings应该是trt.Dims(paddings...吧)
| pre_paddings = [0, 0, 0] | ||
| post_paddings = [0, 0, 0] | ||
|
|
||
| if len(paddings) == 3: |
| post_paddings[0] = paddings[0] | ||
| post_paddings[1] = paddings[1] | ||
| post_paddings[2] = paddings[2] | ||
| elif len(paddings) == 6: |
74 tasks
ZHOU05030
changed the title
vivienfanghuagood
approved these changes
Dec 11, 2024
lizexu123
reviewed
Dec 16, 2024
| } | ||
| } | ||
|
|
||
| if (op->HasAttribute("output_padding")) { |
| if (op->HasAttribute("padding_algorithm")) { | ||
| auto padding_algorithm = | ||
| op->attribute<pir::StrAttribute>("padding_algorithm").AsString(); | ||
| if (padding_algorithm == "SAME") { |
There was a problem hiding this comment.
这里不对，如果是conv3d_transpose且是same且不是动态shape,则return false
| if paddle_op.name() == "pd_op.conv3d": | ||
| input_tensor, filter = inputs | ||
| elif paddle_op.name() == "pd_op.conv3d_transpose": | ||
| if len(inputs) == 3: |
| input_tensor, filter, output_size = inputs | ||
| elif len(inputs) == 2: | ||
| input_tensor, filter = inputs | ||
| output_size = None |
lizexu123
reviewed
Dec 16, 2024
| return conv(x) | ||
|
|
||
|
|
||
| class TestConv3dTRTPattern(TensorRTBaseTest): |
There was a problem hiding this comment.
单测太少了，再测试下padding_algorithm为SAME，为valid和EXPLICIT，把conv3d_transpose补上吧，
74 tasks
|
Sorry to inform you that 4e377ec's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
新增pd_op.conv3d and pd_op.conv3d_transpose