Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][Typos][D-[13-19]] Fix typos (delet, dependecies, dependecy, decprecated, derivated, descripor, deserailize) #69766

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[CodeStyle][Typos][D-[13-19]] Fix typos (delet, dependecies, dependecy, decprecated, derivated, descripor, deserailize) #69766

merged 2 commits into from
Nov 28, 2024

Conversation

winffke
Copy link
Contributor

@winffke winffke commented Nov 27, 2024

PR Category

User Experience

PR Types

Devs

Description

Fix:

  • delet
  • dependecies
  • dependecy
  • decprecated
  • derivated
  • descripor
  • deserailize

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 27, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 27, 2024
@SigureMo SigureMo changed the title [CodeStyle][Typos][D-[13-19]] Fix typo(delet、dependecies、dependecy、decprecated、derivated、descripor、deserailize) [CodeStyle][Typos][D-[13-19]] Fix typos (delet, dependecies, dependecy, decprecated, derivated, descripor, deserailize) Nov 27, 2024
SigureMo
SigureMo approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

CI 挂的有点多，但感觉与 PR 无关，先 rerun 观察下

python/paddle/incubate/distributed/fleet/parameter_server/distribute_transpiler/__init__.py
@@ -869,7 +869,7 @@ def _build_trainer_programs(self, compiled_config):
# for startup program
_startup = worker.fake_init_ops_pass(_startup, compiled_config)
_startup = worker.init_from_server_pass(_startup, compiled_config)
_startup = worker.delet_extra_optimizes_pass(
_startup = worker.delete_extra_optimizes_pass(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还修了个 bug 😂

@SigureMo SigureMo mentioned this pull request Nov 27, 2024
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 28, 2024
@luotao1 luotao1 self-assigned this Nov 28, 2024
@luotao1 luotao1 merged commit bf9019f into PaddlePaddle:develop Nov 28, 2024
28 checks passed
@winffke winffke mentioned this pull request Dec 3, 2024
Open
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@LiYuRio LiYuRio Awaiting requested review from LiYuRio LiYuRio is a code owner

@ForFishes ForFishes Awaiting requested review from ForFishes ForFishes is a code owner

@zhiqiu zhiqiu Awaiting requested review from zhiqiu zhiqiu is a code owner

@JiabinYang JiabinYang Awaiting requested review from JiabinYang JiabinYang is a code owner

@phlrain phlrain Awaiting requested review from phlrain phlrain is a code owner

Assignees

@luotao1 luotao1

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winffke @CLAassistant @SigureMo @luotao1