-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCU][Paddle TensorRT No.31]Add greater_equal and greater_equal_ converter #69770
base: develop
Are you sure you want to change the base?
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
} | ||
}; | ||
|
||
class GreaterEqual_OpPattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
两个greater_equal有大量的代码重复,复用
greater_layer_output = add_elementwise_layer( | ||
network, paddle_op, inputs, trt.ElementWiseOperation.GREATER | ||
) | ||
equal_layer_output = add_elementwise_layer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里写的不对,参考pd_op.remainder,应该就第一个需要add_elementwise_layer
def test_trt_result(self): | ||
self.check_trt_result() | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加一个Marker单测,为了过ci
return false; | ||
} | ||
#endif | ||
op->set_attribute(kCanRunTrtAttr, rewriter.bool_attr(true)); | ||
return true; | ||
} | ||
}; | ||
using GreaterEqual1OpPattern = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pd_op.greater_than不符合这里的检查规则吗
Sorry to inform you that 5882b68's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
PR Category
User Experience
PR Types
New features
Description
add greater_equal and greater_equal_ converter