Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCU][Paddle TensorRT No.31]Add greater_equal and greater_equal_ converter #69770

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

wwwuyan
Copy link
Contributor

@wwwuyan wwwuyan commented Nov 27, 2024

PR Category

User Experience

PR Types

New features

Description

add greater_equal and greater_equal_ converter

Copy link

paddle-bot bot commented Nov 27, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 27, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Nov 28, 2024
}
};

class GreaterEqual_OpPattern
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两个greater_equal有大量的代码重复,复用

greater_layer_output = add_elementwise_layer(
network, paddle_op, inputs, trt.ElementWiseOperation.GREATER
)
equal_layer_output = add_elementwise_layer(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里写的不对,参考pd_op.remainder,应该就第一个需要add_elementwise_layer

def test_trt_result(self):
self.check_trt_result()


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一个Marker单测,为了过ci

return false;
}
#endif
op->set_attribute(kCanRunTrtAttr, rewriter.bool_attr(true));
return true;
}
};
using GreaterEqual1OpPattern =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd_op.greater_than不符合这里的检查规则吗

Copy link

paddle-ci-bot bot commented Dec 14, 2024

Sorry to inform you that 5882b68's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants