Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【SCU】【Paddle Tensor No.7】新增 Tensor.__rxor__ 复用已有接口Tensor.__xor__ #69779

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

yangrongxinuser
Copy link
Contributor

PR Category

User Experience

PR Types

New features

Description

Paddle Tensor 规范化:新增 Tensor.rxor ,复用已有接口 Tensor.xor

Copy link

paddle-bot bot commented Nov 28, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 28, 2024
@yangrongxinuser
Copy link
Contributor Author

@HydrogenSulfate,辛苦老师看看还有什么问题

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

咦这里为啥要删掉呢?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没啥问题,但是pre-commit.yaml这个不能改吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我的电脑名是中文的,所以该路径下会乱码,这个merge-conflicts钩子一直过不了

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我的电脑名是中文的,所以该路径下会乱码,这个merge-conflicts钩子一直过不了

你先把文件还原回去,然后git add,然后git commit "提交信息" -n就行了,末尾加上-n忽略检查钩子

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,老师,那剩下几个没通过的测试是什么原因呢,我看日志里,actual array和desired array是一样的,不知道是什么原因

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,老师,那剩下几个没通过的测试是什么原因呢,我看日志里,actual array和desired array是一样的,不知道是什么原因

剩下的几个可能是测试机器问题导致的,已经帮你重新运行了

@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Nov 28, 2024
@luotao1
Copy link
Contributor

luotao1 commented Nov 28, 2024

@yangrongxinuser 需要在之前的PR上修改,提交commit。不能每次提交新开一个PR,这样会丢失之前的评论意见。

@yangrongxinuser
Copy link
Contributor Author

老师,这个CI测试没有通过是什么原因呢,我点击重新构建,他说我这边没有权限
@HydrogenSulfate

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 1a58803 into PaddlePaddle:develop Nov 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants