[CINN][Backend Pass Update No.3] Update extern_call_process pass #70191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
请先完成对应的注释任务 |
74 tasks
paddle/cinn/optim/optimize.cc
Outdated
| // ExternCallMultiOutputShallowStore(&copied->body); | ||
| BlockPassManager pass_manager; | ||
| pass_manager.AddPass(CreateExternCallMultiOutputShallowStorePass()); | ||
| pass_manager.AddPass(CreateExternCallRemoveTupleGetStatementsPass()); |
There was a problem hiding this comment.
ExternCallRemoveTupleGetStatements没有使用，且之前没有实现，可以不实现并删除
Comment on lines
31
to
33
| if (call && call->is_extern_call() && !call->write_args.empty()) { | ||
| new_stmts.emplace_back(store_op->value); | ||
| } else { |
There was a problem hiding this comment.
call现在是个Expr，如果要它脱离store成为一条stmt需要使用Evaluate stmt包装一下
|
等到加注释任务合入后可以将注释迁移一下，建议是直接将原头文件重命名然后加上新的修改，这样commit能自动绑定映射一下 |
好的 |
Albresky
force-pushed
the
cinn-pass-extern_call_process
branch
2 times, most recently
from
6d830fd to
6e526f5
Compare
Hongqing-work
approved these changes
Dec 25, 2024
Comment on lines
+102
to
+108
| // ExternCallMultiOutputShallowStore(&copied->body); | ||
| BlockPassManager pass_manager0; | ||
| pass_manager0.AddPass(CreateExternCallMultiOutputShallowStorePass()); | ||
| pass_manager0.Run(copied); | ||
| VLOG(10) << "After Optimize ExternCallMultiOutputShallowStore and " | ||
| "ExternCallRemoveTupleGetStatements:" | ||
| << copied; |
There was a problem hiding this comment.
这里打印可以之后的PR再顺带修改一下，注释也可以删除了
There was a problem hiding this comment.
这里打印可以之后的PR再顺带修改一下，注释也可以删除了
好的
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
改造了 extern_call_process Pass