Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][Typos][[N-[1-5],N-[9-10],N-[12-14]] Fix typo(namess, nams, neccessary, Neet, neet, neeed, nedd,neighor,netwrok,normlize,noraml,numer) #70283

Merged
merged 4 commits into from
Dec 20, 2024
Merged

[CodeStyle][Typos][[N-[1-5],N-[9-10],N-[12-14]] Fix typo(namess, nams, neccessary, Neet, neet, neeed, nedd,neighor,netwrok,normlize,noraml,numer) #70283

merged 4 commits into from
Dec 20, 2024

Conversation

yinfan98
Copy link
Contributor

@yinfan98 yinfan98 commented Dec 17, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Others

Description

Fix typos~

  • neighor
  • netwrok
  • normlize
  • noraml
  • numer

_tomls统一在这个文件里改
太麻烦了，于是决定在一个PR里一把梭了zzz

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 17, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 17, 2024
SigureMo
SigureMo previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Member

这个也冲突了

@SigureMo SigureMo mentioned this pull request Dec 18, 2024
Closed
@MrXnneHang
Copy link
Contributor 

neighor
netwrok
normlize
noraml
numer
namess
nams
neccessary
{Neet, neet, neeed, nedd}

你可以把这些都集中在这个PR的_typos.toml里面删，然后把另一个PR里的typos.toml同步一下最新develop分支。

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 18, 2024
@yinfan98 yinfan98 changed the title [CodeStyle][Typos][N-[9,10],N-[12-14]] Fix typo(neighor,netwrok,normlize,noraml,numer) [CodeStyle][Typos][[N-[1-5],N-[9,10],N-[12-14]] Fix typo(namess, nams, neccessary, Neet, neet, neeed, nedd,neighor,netwrok,normlize,noraml,numer) Dec 19, 2024
@yinfan98
Copy link
Contributor Author

一把梭哈了，另一个PR关掉了🥲

SigureMo
SigureMo approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo mentioned this pull request Dec 19, 2024
Open
@luotao1 luotao1 merged commit e871b7d into PaddlePaddle:develop Dec 20, 2024
28 checks passed
@SigureMo SigureMo changed the title [CodeStyle][Typos][[N-[1-5],N-[9,10],N-[12-14]] Fix typo(namess, nams, neccessary, Neet, neet, neeed, nedd,neighor,netwrok,normlize,noraml,numer) [CodeStyle][Typos][[N-[1-5],N-[9-10],N-[12-14]] Fix typo(namess, nams, neccessary, Neet, neet, neeed, nedd,neighor,netwrok,normlize,noraml,numer) Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@zrr1999 zrr1999 Awaiting requested review from zrr1999 zrr1999 is a code owner

@gouzil gouzil Awaiting requested review from gouzil gouzil is a code owner

@LiYuRio LiYuRio Awaiting requested review from LiYuRio LiYuRio is a code owner

@ForFishes ForFishes Awaiting requested review from ForFishes ForFishes is a code owner

@zhiqiu zhiqiu Awaiting requested review from zhiqiu zhiqiu is a code owner

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yinfan98 @SigureMo @MrXnneHang @luotao1