Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][Typos][M-6] fix typos Maxinum -> Maximum #70474

Merged
merged 1 commit into from
Dec 26, 2024
Merged

[CodeStyle][Typos][M-6] fix typos Maxinum -> Maximum #70474

merged 1 commit into from
Dec 26, 2024

Conversation

jinyouzhi
Copy link
Contributor

@jinyouzhi jinyouzhi commented Dec 25, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Devs

Description

fixed:
maximum

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 25, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 25, 2024
@jinyouzhi
Copy link
Contributor Author

@SigureMo

@SigureMo
Copy link
Member

需要修改 _typos.toml，我自然会感知

@SigureMo
Copy link
Member

标题也需要改一下，参考其他 PR

@SigureMo
Copy link
Member

喔 我知道了，这是别人漏掉的 😂，那没事了

@jinyouzhi
Copy link
Contributor Author

需要修改 _typos.toml，我自然会感知

这条已经修过了，这4行是#69337 引入的

@SigureMo
Copy link
Member

这条已经修过了，这4行是#69337 引入的

嗯 刚看到了，我确认下流水线是否有豁免行为

@SigureMo
Copy link
Member

嗯 刚看到了，我确认下流水线是否有豁免行为

https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/12100806/job/28341357

看样子流水线通过时间刚好在一周内，没有触发强制重跑

SigureMo
SigureMo approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo changed the title [CodeStyle] fix typos Maxinum -> Maximum [CodeStyle][Typos] fix typos Maxinum -> Maximum Dec 25, 2024
@SigureMo SigureMo changed the title [CodeStyle][Typos] fix typos Maxinum -> Maximum [CodeStyle][Typos][M-6] fix typos Maxinum -> Maximum Dec 25, 2024
This was referenced Dec 25, 2024
Open
Merged
@SigureMo SigureMo merged commit 53e65a0 into PaddlePaddle:develop Dec 26, 2024
29 of 31 checks passed
@SigureMo SigureMo added the HappyOpenSource 快乐开源活动issue与PR label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinyouzhi @CLAassistant @SigureMo