[XPU] support python streams api for xpu #73924

runzhech · 2025-07-09T06:32:56Z

PR Category

Custom Device

PR Types

New features

Description

支持python测调用xpu的stream、event等接口

paddle-bot · 2025-07-09T06:33:03Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/fluid/pybind/xpu_streams_py.cc

paddle/phi/api/include/tensor.h

paddle/phi/backends/xpu/xpu_context.h

codecov-commenter · 2025-07-18T12:34:46Z

Codecov Report

❌ Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@1987f7c). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
python/paddle/device/__init__.py	27.27%	8 Missing ⚠️
python/paddle/device/xpu/__init__.py	20.00%	8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (27.27%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #73924   +/-   ##
==========================================
  Coverage           ?   27.27%           
==========================================
  Files              ?        3           
  Lines              ?       22           
  Branches           ?        0           
==========================================
  Hits               ?        6           
  Misses             ?       16           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mayang002 · 2025-07-29T06:07:59Z

paddle/phi/backends/xpu/xpu_context.cc


 int64_t XPUContext::GetStreamNum() const { return impls_.size(); }

+int XPUContext::SetCurrentStream(int idx) {


如果 idx == prev_stream_idx，直接返回。

mayang002 · 2025-07-29T06:08:26Z

paddle/phi/backends/xpu/xpu_context.cc

+  int prev_stream_idx = current_stream_idx;
+  impls_[0]->SetStream(stream_pool[idx]);
+  current_stream_idx = idx;
+  idle_stream_flags[prev_stream_idx] = true;


idle_stream_flags[current_stream_idx] 设置为 false

mayang002 · 2025-07-29T06:09:22Z

paddle/phi/backends/xpu/xpu_context.cc

+      break;
+    }
+  }
+  if (found_idle_stream) {


如果 found，还需要把 idle_stream_flags 对应位置设置为 false

…eams

runzhech · 2025-08-05T07:29:54Z

/re-run all-failed

HarperCy

LGTM

cqulilujia · 2025-08-05T12:02:23Z

python/paddle/device/xpu/__init__.py

+    Return the current CUDA stream by the device.
+
+    Args:
+        device(paddle.CUDAPlace()|int|None, optional): The device or the ID of the device which want to get stream from.


paddle.XPU**

cqulilujia

LGTM

runzhech · 2025-08-05T15:17:27Z

/re-run all-failed

runzhech · 2025-08-06T06:10:56Z

/re-run all-failed

tianshuo78520a

Approve print

yongqiangma

LGTM

XiaoguangHu01

LGTM

sunzhongkai588

LGTM。记得补充中文文档

runzhech · 2025-08-07T09:11:50Z

/re-run all-failed

tizhou86

LGTM

dynamicheart · 2025-08-07T09:53:53Z

paddle/phi/backends/xpu/xpu_context.cc

  } else {
    impls_.push_back(std::make_unique<Impl>());
    impls_[0]->Init(get_gm_size(0), get_l3_size(0));
+    stream_pool.push_back(impls_[0]->context_->get_stream());


TODO：如果开启XPU_CDNN_CLUSTER_PARALLEL，则stream的相关接口就会有问题。

dynamicheart

LGTM

dynamicheart · 2025-08-07T09:55:37Z

paddle/fluid/pybind/tensor.cc

                 paddle::platform::GetXPUCurrentDeviceId();
             auto stream = paddle::platform::get_current_stream(device_id);
-             xpu_wait(stream);
+             xpu_wait(stream->raw_stream());


未检查返回值，下个PR修复

dynamicheart · 2025-08-07T09:56:09Z

paddle/phi/backends/xpu/xpu_context.cc

-    if (context_->xpu_stream != nullptr && stream_owned_) {
+  void SetStream(void* stream, bool clear = true) {
+    if (clear && context_->xpu_stream != nullptr && stream_owned_) {
      xpu_stream_destroy(context_->xpu_stream);


未检查返回值，下个PR修复

dynamicheart · 2025-08-07T09:56:58Z

paddle/phi/core/platform/device/xpu/xpu_resource_pool.cc

      phi::backends::xpu::XPUDeviceGuard guard(dev_idx);
-      xpu_event_destroy(event);
+      if (xpu_event_query(event) == XPU_SUCCESS) {
+        xpu_event_destroy(event);


未检查返回值，下个PR修复

* [XPU] support python streams api for xpu * [XPU] support python streams api for xpu * [XPU] add stream & event unittests

paddle-bot bot added the XPU label Jul 9, 2025

runzhech force-pushed the streams branch from b4688e3 to 930ecb7 Compare July 9, 2025 09:39

runzhech requested review from YuanRisheng, phlrain and zyfncg as code owners July 9, 2025 09:39

runzhech force-pushed the streams branch from 930ecb7 to 4a69fdf Compare July 9, 2025 11:09

runzhech force-pushed the streams branch 2 times, most recently from 069f46f to 90309e4 Compare July 18, 2025 05:52

zhupengyang reviewed Jul 18, 2025

View reviewed changes

runzhech force-pushed the streams branch 5 times, most recently from 133617d to 67f6f1b Compare July 23, 2025 11:34

mayang002 reviewed Jul 29, 2025

View reviewed changes

runzhech force-pushed the streams branch 6 times, most recently from 3f1f8c7 to 92bf114 Compare July 31, 2025 10:33

[XPU] support python streams api for xpu

9dfce88

runzhech force-pushed the streams branch from b81a4dc to 9dfce88 Compare August 1, 2025 04:55

runzhech added 2 commits August 1, 2025 13:08

Merge branch 'develop' into streams

5d355ef

[XPU] support python streams api for xpu

99b1b12

runzhech force-pushed the streams branch from 7ce823e to 9534268 Compare August 1, 2025 07:40

runzhech force-pushed the streams branch 2 times, most recently from 469181a to 814126e Compare August 4, 2025 16:40

Merge branch 'streams' of https://github.com/runzhech/Paddle into str…

e1222a1

…eams

runzhech force-pushed the streams branch from 814126e to e1222a1 Compare August 5, 2025 01:42

[XPU] add stream & event unittests

dbfc304

runzhech force-pushed the streams branch from f35dec9 to dbfc304 Compare August 5, 2025 04:21

HarperCy approved these changes Aug 5, 2025

View reviewed changes

mayang002 approved these changes Aug 5, 2025

View reviewed changes

cqulilujia reviewed Aug 5, 2025

View reviewed changes

cqulilujia approved these changes Aug 5, 2025

View reviewed changes

runzhech force-pushed the streams branch 2 times, most recently from e68294a to 7a0e2cb Compare August 6, 2025 16:18

Merge branch 'PaddlePaddle:develop' into streams

9cb0e03

runzhech force-pushed the streams branch from 7a0e2cb to 9cb0e03 Compare August 6, 2025 17:01

tianshuo78520a added the skip-ci: coverage label Aug 7, 2025

tianshuo78520a approved these changes Aug 7, 2025

View reviewed changes

yongqiangma approved these changes Aug 7, 2025

View reviewed changes

zyfncg approved these changes Aug 7, 2025

View reviewed changes

XiaoguangHu01 approved these changes Aug 7, 2025

View reviewed changes

sunzhongkai588 approved these changes Aug 7, 2025

View reviewed changes

tizhou86 approved these changes Aug 7, 2025

View reviewed changes

dynamicheart reviewed Aug 7, 2025

View reviewed changes

dynamicheart approved these changes Aug 7, 2025

View reviewed changes

dynamicheart merged commit 97fd314 into PaddlePaddle:develop Aug 7, 2025
76 of 79 checks passed

runzhech deleted the streams branch August 8, 2025 06:06

Enigmatisms pushed a commit to Enigmatisms/Paddle that referenced this pull request Aug 9, 2025

[XPU] support python streams api for xpu (PaddlePaddle#73924)

e6b8ad1

* [XPU] support python streams api for xpu * [XPU] support python streams api for xpu * [XPU] add stream & event unittests


		int64_t XPUContext::GetStreamNum() const { return impls_.size(); }

		int XPUContext::SetCurrentStream(int idx) {

[XPU] support python streams api for xpu #73924

[XPU] support python streams api for xpu #73924

Uh oh!

Conversation

runzhech commented Jul 9, 2025

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

runzhech commented Aug 5, 2025

Uh oh!

HarperCy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cqulilujia left a comment

Choose a reason for hiding this comment

Uh oh!

runzhech commented Aug 5, 2025

Uh oh!

runzhech commented Aug 6, 2025

Uh oh!

tianshuo78520a left a comment

Choose a reason for hiding this comment

Uh oh!

yongqiangma left a comment

Choose a reason for hiding this comment

Uh oh!

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Uh oh!

sunzhongkai588 left a comment

Choose a reason for hiding this comment

Uh oh!

runzhech commented Aug 7, 2025

Uh oh!

tizhou86 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dynamicheart left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

codecov-commenter commented Jul 18, 2025 •

edited

Loading