Skip to content

Conversation

@ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Jul 18, 2025

PR Category

User Experience

PR Types

Others

Description

#72709
refine full and full_like for fill_value type check and annotations

@paddle-bot
Copy link

paddle-bot bot commented Jul 18, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@6aba423). Learn more about missing BASE report.

Files with missing lines Patch % Lines
python/paddle/tensor/creation.py 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #74127   +/-   ##
==========================================
  Coverage           ?   80.00%           
==========================================
  Files              ?        1           
  Lines              ?        5           
  Branches           ?        0           
==========================================
  Hits               ?        4           
  Misses             ?        1           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 21, 2025
"""
# Include str type check to handle string numeric values like "0.5" that occur in CI tests.
# The compatible method for fliud operators, may be it can be removed in the future.
if not isinstance(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不在支持bool类型,是否会对套件库的兼容性产生影响?

Copy link
Contributor Author

@ooooo-create ooooo-create Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 的 bool 类型是支持的~
图片

numpy.bool 目前本身是不支持的,现在的判断是会拦截的,应该不会有影响,就是报错位置提前了
图片

@ooooo-create
Copy link
Contributor Author

/re-run all-failed

1 similar comment
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

wawltor
wawltor previously approved these changes Aug 11, 2025
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Aug 11, 2025

test_imperative_auto_mixed_precision_for_eager 可能是随机挂 @ooooo-create 可以merge下develop再试试

@ooooo-create
Copy link
Contributor Author

/re-run all-failed

2 similar comments
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@luotao1
Copy link
Contributor

luotao1 commented Aug 15, 2025

冲突了

@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@luotao1 luotao1 merged commit eead246 into PaddlePaddle:develop Aug 19, 2025
97 of 102 checks passed
Luckycheng222 pushed a commit to Luckycheng222/Paddle that referenced this pull request Aug 25, 2025
…addlePaddle#74127)

* refine full and full_like for fill_value check and type annotations

* refine

* refine

* refine

* pass approve ci

* refine code

* adapt string numeric values usage

* add more comments

* add more tests
@ooooo-create ooooo-create deleted the r1 branch September 29, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants