Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enbale auto set env of V1 on Mac #7413

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Conversation

tensor-tang
Copy link
Contributor

@tensor-tang tensor-tang commented Jan 10, 2018

本地快速测试了下,paddle train 没有加任何参数,截止到train之前没有出现 /proc/cpuinfo 不识别之类的问题了。

@luotao1
Copy link
Contributor

luotao1 commented Jan 11, 2018

@kuke 能否帮忙在Mac上验证一下效果

  • Mac本地编译,编译时请去掉下面的注释,这样运行时能打印出对应的线程数。
# echo $OMP_NUM_THREADS $MKL_NUM_THREADS $OPENBLAS_NUM_THREADS

这句注释在submit_local.sh.in#L176

@tensor-tang
Copy link
Contributor Author

用那两个脚本直接run可能不是很合适,因为脚本里面用到了nproc,这个在mac里面是不认识的。

需要要验证的话,直接run一下 空的 paddle train,看那几个变量是不是有值就好了。

如果要验证在Mac上的效果就是另外一个故事了,当前PR主要是想要解决用Mac直接跑V1的时候,报出不识别文件等问题,只不过顺便添加了与v2相同的设置。

@tensor-tang
Copy link
Contributor Author

有一个issue需要备注下#7472,,这个问题是排除当前PR也会出现的。

@luotao1 luotao1 requested a review from kuke January 12, 2018 07:30
@kuke
Copy link
Contributor

kuke commented Jan 12, 2018

在mac上跑的时候遇到了这个问题#7476, 不过

# echo $OMP_NUM_THREADS $MKL_NUM_THREADS $OPENBLAS_NUM_THREADS

输出为空

Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 04bfed6 into PaddlePaddle:develop Jan 12, 2018
@tensor-tang tensor-tang deleted the v1mac branch January 12, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants