Compatible with torch 3rd #74402
Merged
Compatible with torch 3rd #74402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
…Paddle/Paddle into compatible-with-torch-3rd
…ass to avoid warnings
…Paddle/Paddle into compatible-with-torch-3rd
SigureMo
previously approved these changes
Aug 30, 2025
SigureMo
approved these changes
Aug 30, 2025
| # Add paddle_includes to pass CI, for more details, | ||
| # please refer to the comments in `paddle/tests/custom_op/utils.py`` | ||
| paddle_includes = [] | ||
| for site_packages_path in getsitepackages(): |
| classes_[qualified_name] = | ||
| std::make_unique<ClassRegistration>(namespace_name, class_name); | ||
| // TODO(SigureMo): Use vlog for debug logging | ||
| // std::cout << "Registered class: " << qualified_name << std::endl; |
zhangbo9674
approved these changes
Aug 30, 2025
zyfncg
approved these changes
Aug 30, 2025
Comment on lines
+38
to
+56
| inline at::Tensor empty(at::IntArrayRef size, | ||
| ::std::optional<at::ScalarType> dtype, | ||
| ::std::optional<at::Layout> layout, | ||
| ::std::optional<at::Device> device, | ||
| ::std::optional<bool> pin_memory, | ||
| ::std::optional<at::MemoryFormat> memory_format) { | ||
| PD_CHECK(!layout.has_value(), "`layout` is not supported now."); | ||
| PD_CHECK(!(pin_memory.has_value() && pin_memory.value() != false), | ||
| "`pin_memory` other than False is not supported now."); | ||
| PD_CHECK(!(memory_format.has_value() && | ||
| memory_format.value() != c10::MemoryFormat::Contiguous), | ||
| "`MemoryFormat` other than Contiguous is not supported now."); | ||
|
|
||
| return paddle::experimental::empty( | ||
| size._PD_ToPaddleIntArray(), | ||
| compat::_PD_AtenScalarTypeToPhiDataType( | ||
| dtype.value_or(c10::get_default_dtype())), | ||
| device.value_or(at::kCPU)._PD_GetInner()); | ||
| } |
Contributor
There was a problem hiding this comment.
能否把这些头文件的实现逻辑放到.cc中，否则使用时很容易编译体积膨胀
Contributor
Author
There was a problem hiding this comment.
能否把这些头文件的实现逻辑放到.cc中，否则使用时很容易编译体积膨胀
好的，后续统一调整一下，一开始这样写主要是和torch的结构统一。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
pcard-67164
convert torch C++ api to paddle api