Skip to content

Conversation

@enkilee
Copy link
Contributor

@enkilee enkilee commented Aug 11, 2025

PR Category

Execute Infrastructure

PR Types

Others

Description

cuda_graph_instruction.h:61:19: warning: ‘paddle::framework::CudaGraphInstruction::op_’ will be initialized after [-Wreorder]
   pir::Operation* op_;
                   ^~~
cuda_graph_instruction.h:60:21: warning:   ‘const phi::Place& paddle::framework::CudaGraphInstruction::place_’ [-Wreorder]
   const phi::Place& place_;
                     ^~~~~~
cuda_graph_instruction.cc:41:1: warning:   when initialized here [-Wreorder]
 CudaGraphInstruction::CudaGraphInstruction(
 ^~~~~~~~~~~~~~~~~~~~
cuda_graph_instruction.cc:98:8: warning: variable ‘is_last_op’ set but not used [-Wunused-but-set-variable]
   bool is_last_op = true;

change sequence for op and place in .cc file.
add [[maybe_unused]] for is_last_op

@paddle-bot
Copy link

paddle-bot bot commented Aug 11, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 11, 2025
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 11, 2025
@luotao1 luotao1 self-assigned this Aug 11, 2025
@enkilee
Copy link
Contributor Author

enkilee commented Aug 12, 2025

/re-run all-failed

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@7072535). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...new_executor/instruction/cuda_graph_instruction.cc 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #74533   +/-   ##
==========================================
  Coverage           ?    0.00%           
==========================================
  Files              ?        1           
  Lines              ?        2           
  Branches           ?        0           
==========================================
  Hits               ?        0           
  Misses             ?        2           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luotao1 luotao1 merged commit 65e2105 into PaddlePaddle:develop Aug 12, 2025
99 of 105 checks passed
maxiaolong001 pushed a commit to maxiaolong001/Paddle that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants