-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[API compatibility] add scatter_reduce api #74564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API compatibility] add scatter_reduce api #74564
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74564 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 1
Lines ? 21
Branches ? 0
===========================================
Hits ? 21
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
python/paddle/tensor/manipulation.py
Outdated
| return result | ||
|
|
||
|
|
||
| @ParamAliasDecorator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是新增API,参数名直接与torch一致吧,不用再alias映射了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| index: Tensor, | ||
| src: Tensor, | ||
| reduce: Literal['sum', 'prod', 'mean', 'amin', 'amax'], | ||
| include_self: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torch这个是指定关键字用法,我们也按这样放到*后面去
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ed08c56
|
/re-run all-failed |
2 similar comments
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run all-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add scatter reduce api * cancel paramAliasDecorator * add keyword-only * fix test scatter reduce * fix test note * fix testscase and static check
PR Category
User ExperiencePR Types
New featuresDescription
Add scatter_reduce api for paddle, similar to torch.scatter_reduce