[Accuracy diff No.168] Fix accuracy (output type) diff for paddle.floor and paddle.ceil API #74598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
/re-run all-failed |
1 similar comment
Contributor
Author
|
/re-run all-failed |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #74598 +/- ##
==========================================
Coverage ? 83.33%
==========================================
Files ? 3
Lines ? 12
Branches ? 0
==========================================
Hits ? 10
Misses ? 2
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
wanghuancoder
approved these changes
Aug 18, 2025
| Returns: | ||
| Tensor. Output of Floor operator, a Tensor with shape same as input | ||
| (integer types are autocasted into float32). |
Contributor
Author
There was a problem hiding this comment.
zyfncg
approved these changes
Aug 18, 2025
Luckycheng222
pushed a commit
to Luckycheng222/Paddle
that referenced
this pull request
Aug 25, 2025
…or and paddle.ceil API (PaddlePaddle#74598) * fix(activation_kernel.cc/cu): fix output type diff for floor/ceil kernel * fix(test_activation_op.py): add unit test * fix(full_kernel.cc/cu): add int8 support for full_like * fix(activation_functor.h): fix floor/ceil functor for int dtype input * fix(test_activation_op.py): add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
Currently, the
floorandceilkernel exhibits different output types between PyTorch and Paddle. For instance, when the input datatype isint32, PyTorch outputsint32, whereas Paddle outputsfloat32. The same isceil.This is because
floorandceilare conducted type promotion.This PR
pcard-67164