[API compatibility] ignore _stacklevel, make parameter name compatible with input and dim, support paddle.softmax, paddle.Tensor.softmax #74651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Aug 18, 2025
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
Contributor
There was a problem hiding this comment.
单独把这个softmax挪出来，我感觉似乎不太合理，这个循环导入问题，还有其他一些解决方式没。
或者tensor目录下面，是不是更合理点
|
|
||
| @ParamAliasDecorator({"x": ["input"], "axis": ["dim"]}) | ||
| @ParamIgnoreDecorator([('_stacklevel', 2, int)]) | ||
| def softmax( |
Contributor
There was a problem hiding this comment.
这个装饰器太多了，对性能影响比较大，你可以优化下装饰器的写法，至多走一个装饰器，尽可能减少判断逻辑与分支，每次if else都有损耗
Contributor
Author
|
/re-run all-failed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #74651 +/- ##
==========================================
Coverage ? 94.00%
==========================================
Files ? 5
Lines ? 50
Branches ? 0
==========================================
Hits ? 47
Misses ? 3
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhwesky2010
approved these changes
Aug 20, 2025
| return args, kwargs | ||
|
|
||
|
|
||
| def ParamIgnoreAndAliasDecorator( |
Contributor
There was a problem hiding this comment.
命名风格与其他的保持统一吧，function采用下划线，class采用驼峰式。你可以下个PR再修改。
SigureMo
approved these changes
Aug 20, 2025
Contributor
Author
|
/re-run all-failed |
Luckycheng222
pushed a commit
to Luckycheng222/Paddle
that referenced
this pull request
Aug 25, 2025
… dim, support paddle.softmax, paddle.Tensor.softmax (PaddlePaddle#74651) * ignore _stacklevel, make parameter name compatible with input and dim * import softmax in activation.py * mv paddle/softmax to tensor/softmax; merge two decorators into one * fix pre-commit * fix import path * fix the logic, replace Class with Function
zhwesky2010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
ignore _stacklevel, make parameter name compatible with input and dim, support paddle.softmax, paddle.Tensor.softmax