-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[API Compatibilities] Add Tensor.mul_, mul, diff, cumsum #74914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Compatibilities] Add Tensor.mul_, mul, diff, cumsum #74914
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
|
|
||
| @param_two_alias(["x", "input"], ["y", "other"]) | ||
| def mul( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiply 下沉至 C++ 后,通过 python 别名调用 multiply 参数传递异常,孙东建议新开个 API
zhwesky2010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个需要处理下冲突
Done |
|
|
||
|
|
||
| @param_two_alias(["x", "input"], ["y", "other"]) | ||
| def mul( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个后续会把multiply迁回来吗,mul和multiply最好不能出现diff。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielSun11 后续可以支持吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后续我支持一下 @zhwesky2010
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #74914 +/- ##
==========================================
Coverage ? 93.75%
==========================================
Files ? 2
Lines ? 16
Branches ? 0
==========================================
Hits ? 15
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
DanielSun11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@SigureMo 辛苦 Reivew 一下~ |
|
/re-run all-failed |
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/re-run all-failed |
PR Category
User Experience
PR Types
New features
Description
为 Tensor.mul_, mul, diff, cumsum 四个 API 做兼容性改造,并将 multiply 下沉至 C++
multiply 下沉至 cpp [API Compatibility] Add out support for 11 APIs #74592 中遗留工作与 [API Compatiblity] sink matmul and multiply #74899 重复