Skip to content

Conversation

@HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Aug 28, 2025

PR Category

Environment Adaptation

PR Types

Others

Description

Pcard-75624

基于 #74918

  1. 添加单测以覆盖更多代码
  2. 拆分test_creation_and_Tensor_creation.py的单测到多个文件
  3. paddle.Tensor.new_ones/empty/zeros支持*size参数
  4. phi::backend支持xpu_pinned设备转换

@paddle-bot
Copy link

paddle-bot bot commented Aug 28, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010
zhwesky2010 previously approved these changes Aug 29, 2025
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate changed the title [Coverage] Add more coverage [API Compatiblity] Add more coverage Aug 29, 2025
zhwesky2010
zhwesky2010 previously approved these changes Aug 29, 2025
XiaoguangHu01
XiaoguangHu01 previously approved these changes Aug 29, 2025
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@151b3e5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/core/compat/convert_utils.cc 0.00% 2 Missing ⚠️
python/paddle/tensor/creation.py 85.71% 2 Missing ⚠️
python/paddle/base/dygraph/tensor_patch_methods.py 75.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (86.48%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #74949   +/-   ##
==========================================
  Coverage           ?   86.48%           
==========================================
  Files              ?        6           
  Lines              ?       37           
  Branches           ?        0           
==========================================
  Hits               ?       32           
  Misses             ?        5           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zhwesky2010
zhwesky2010 previously approved these changes Aug 29, 2025
zhwesky2010
zhwesky2010 previously approved these changes Aug 30, 2025
@HydrogenSulfate HydrogenSulfate merged commit 46cdd05 into PaddlePaddle:develop Aug 30, 2025
73 of 81 checks passed
@HydrogenSulfate HydrogenSulfate deleted the add_more_cov branch August 30, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants