-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance distributed train performance #7608
Enhance distributed train performance #7608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以先merge,然后我再继续整理优化代码。
// Get from multiple trainers, we don't care about the order in which | ||
// the gradients arrives, just add suffix 0~n and merge the gradient. | ||
rpc_service_->SetCond(0); | ||
for (size_t i = 0; i < barrier_size; ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 这一块代码太长了, 导致main loop比较复杂,容易出错。建议改成单独的一个函数。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… distributed_split_selectedrows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Fix #7607