Add python doc for dynamic_lstm #7640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pkuyym
reviewed
Jan 18, 2018
python/paddle/v2/fluid/layers/nn.py
Outdated
|
|
||
| hidden_dim = 512 | ||
| forward_proj = fluid.layers.fc(input=input_seq, size=hidden_dim * 4, | ||
| act='tanh', bias_attr=True) |
There was a problem hiding this comment.
It seems that fc only conduct linear projection, please double check whether it's correct to use act=tanh
There was a problem hiding this comment.
@pkuyym I noticed that param act is not used in fc: https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/fluid/layers/nn.py#L63
So why didn't add activation in fc?
There was a problem hiding this comment.
These are linear projections.
Note that these :math:
W_{xi}x_{t}, W_{xf}x_{t}, W_{xc}x_{t}, W_{xo}x_{t}
operations on the input :math:x_{t}are NOT included in this operator.
Users can choose to use fully-connect layer before LSTM layer.
There was a problem hiding this comment.
Modified the example, set act and bias_attr to None
luotao1
approved these changes
Jan 19, 2018
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #7641