Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some dead links in doc/ #806

Merged
merged 3 commits into from
Dec 13, 2016
Merged

fix some dead links in doc/ #806

merged 3 commits into from
Dec 13, 2016

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Dec 9, 2016

修复英文目录下一些链接失效的问题。

@luotao1 luotao1 requested a review from qingqing01 December 9, 2016 09:30
reyoung
reyoung requested changes Dec 9, 2016
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请尽量使用ref来修复连接，这样可以一劳永逸。

参考#807

@luotao1
Copy link
Contributor Author

luotao1 commented Dec 12, 2016

之前的log很乱，重新提交了一份。

  1. 使用ref来修复链接，merge了 Fix dead links in quick start after reorganzing documentaion directory #821 和 Fix dead link after rearrange english documentation. #807 后，目前doc/下面没有链接失效的问题了。
  2. 去掉doc/tutorials/semantic_role_labeling下重复提交的semantic_role_labeling_cn.md（与该目录下的index_cn.md一样）。
  3. 修复gpu_profiling_en.rst中include代码路径不对的地方。

@luotao1 luotao1 mentioned this pull request Dec 12, 2016
Closed
reyoung
reyoung approved these changes Dec 12, 2016
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for reference style, but not look at in details. Please let @qingqing01 add her review.

qingqing01
qingqing01 requested changes Dec 12, 2016
View reviewed changes
doc/howto/deep_model/rnn/rnn_en.rst
@@ -246,6 +246,6 @@ The code is listed below:
outputs(beam_gen)


Notice that this generation technique is only useful for decoder like generation process. If you are working on sequence tagging tasks, please refer to `Semantic Role Labeling Demo <../../demo/semantic_role_labeling/index.html>`_ for more details.
Notice that this generation technique is only useful for decoder like generation process. If you are working on sequence tagging tasks, please refer to :ref:`sentiment_analysis_en` for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该是srl而不是sentiment。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@qingqing01 qingqing01 merged commit 0948ea3 into PaddlePaddle:develop Dec 13, 2016
@luotao1 luotao1 deleted the link branch December 13, 2016 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@reyoung reyoung reyoung approved these changes

Assignees

@qingqing01 qingqing01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luotao1 @reyoung @qingqing01