impl switch op forward part #8140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impl-scalar-switch-case-op
13 tasks
… impl-scalar-switch-case-op
Superjomn
reviewed
Feb 5, 2018
| @@ -46,6 +47,7 @@ message OpDesc { | |||
| repeated bool bools = 11; | |||
| optional int32 block_idx = 12; | |||
| optional int64 l = 13; | |||
| repeated int32 block_idxs = 14; | |||
There was a problem hiding this comment.
what's the relation between block_idx and block_idxs?
can they merge into one field? given optional = repeated[size=0+]
There was a problem hiding this comment.
block_idxs = vector<block_idx>
There was a problem hiding this comment.
I will take a look if they can be merged
… impl-scalar-switch-case-op
|
will implement in #8184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #8142
project: #7769