Refine prior_box_op #8151
Merged
Refine prior_box_op #8151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Feb 5, 2018
paddle/operators/prior_box_op.cc
Outdated
| .SetDefault(0.0); | ||
| .SetDefault(0.0) | ||
| .AddCustomChecker([](const float& step_w) { | ||
| PADDLE_ENFORCE_GT(step_w, 0.0, "step_h should be larger than 0."); |
There was a problem hiding this comment.
step_h should be -> step_w should be
chengduoZH
force-pushed
the
fixbug/prior_box
branch
from
c317825
to
d7a371c
Compare
chengduoZH
force-pushed
the
fixbug/prior_box
branch
from
44268e0
to
98089c4
Compare
chengduoZH
force-pushed
the
fixbug/prior_box
branch
from
98089c4
to
f367ad6
Compare
qingqing01
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checking of attribution should be placed in
OpMaker.The
InferShapeofxxOpand theComputeofxxKernelwill be called every iteration, but the attribution is immutable. So it just needs to be checked once.