Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine buffer receive #8179

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Refine buffer receive #8179

merged 1 commit into from
Feb 6, 2018

Conversation

chengduoZH
Copy link
Contributor

fix: If there are residual values in a closed buffered channel, receive should be able to retrieve them.

abhinavarora
abhinavarora approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the PR

@chengduoZH chengduoZH merged commit a07b751 into PaddlePaddle:develop Feb 6, 2018
@kavyasrinet
Copy link

Thank you so much!

@chengduoZH chengduoZH deleted the feature/refine_buffer_receive branch February 6, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavarora abhinavarora abhinavarora approved these changes

@kavyasrinet kavyasrinet Awaiting requested review from kavyasrinet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chengduoZH @kavyasrinet @abhinavarora