Add target assigner operator for SSD detection. #8193

qingqing01 · 2018-02-06T11:42:41Z

Support CPU and GPU.
There are 4 outputs:
- target bboxes with shape [N, Np, 4].
- weight for target bboxes with shape [N, Np, 1].
- target labels with shape [N, Np, 1].
- weight for target labels with shape [N, Np, 1].

… ssd_target_assign

wanghaox · 2018-02-07T02:04:55Z

paddle/operators/target_assign_op.cc

@@ -0,0 +1,172 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


wanghaox · 2018-02-07T02:33:52Z

paddle/operators/target_assign_op.cc

+             "labels with shape [Ng, 1], where the Ng is the same as it in "
+             "the input of EncodedGTBBox.");
+    AddInput("MatchIndices",
+             "(Tensor, default LoDTensor<int>), The input matched indices "


default Tensor<int>

wanghaox · 2018-02-07T02:38:24Z

paddle/operators/target_assign_op.h

@@ -0,0 +1,155 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


wanghaox · 2018-02-07T02:38:51Z

paddle/operators/target_assign_op.cu

@@ -0,0 +1,61 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


wanghaox · 2018-02-07T03:04:21Z

python/paddle/v2/fluid/tests/test_target_assign_op.py

+
+    for n in range(batch_size):
+        gt_num = gt_lod[n + 1] - gt_lod[n]
+        ids = random.sample([i for i in range(num_prior)], gt_num)


sample是截取指定长度的片断，是不是sample前可以再加一个shuffle？

sample采样出来是乱序的：

>>> import random >>> print random.sample([i for i in range(10)], 4) [7, 3, 5, 6]

wanghaox · 2018-02-07T06:06:48Z

paddle/operators/target_assign_op.cc

+             "indics with shape [Neg, 1], where is the total number of "
+             "negative example indices.");
+    AddAttr<int>("background_label",
+                 "(int, default 0), Label id for background class.")


Label id of background class

wanghaox · 2018-02-07T06:08:16Z

paddle/operators/target_assign_op.cc

+                  const size_t* lod, const int num, const int num_prior_box,
+                  const int background_label, int* out_label, T* out_label_wt) {
+    for (int i = 0; i < num; ++i) {
+      for (int j = lod[i]; j < lod[i + 1]; ++j) {


wanghaox · 2018-02-07T06:11:01Z

paddle/operators/target_assign_op.h

+    auto* out_label_wt = ctx.Output<framework::Tensor>("PredScoreWeight");
+
+    PADDLE_ENFORCE_EQ(enc_gt_box->lod().size(), 1UL);
+    PADDLE_ENFORCE_EQ(gt_label->lod().size(), 1UL);


检查 gt_label->lod()和 enc_gt_box->lod() 的值是一致的

Done in following code.

wanghaox · 2018-02-07T06:11:52Z

python/paddle/v2/fluid/tests/test_target_assign_op.py

+
+import unittest
+import numpy as np
+import math


没有用math，可以删除

wanghaox · 2018-02-07T06:12:10Z

python/paddle/v2/fluid/tests/test_target_assign_op.py

+import unittest
+import numpy as np
+import math
+import sys


没有用sys，可以删除

chengduoZH · 2018-02-07T06:49:10Z

paddle/operators/target_assign_op.h

+    T* obox = out_box_ + (row * num_prior_box_ + col) * 4;
+    int* olabel = out_label_ + row * num_prior_box_ + col;
+    T* obox_wt = out_box_wt_ + row * num_prior_box_ + col;
+    T* olabel_wt = out_label_wt_ + row * num_prior_box_ + col;


row * num_prior_box_ has computed many times in kernel. It can be optimized.

chengduoZH · 2018-02-07T06:57:21Z

paddle/operators/target_assign_op.cu

+  for (int i = st + threadIdx.x; i < ed; i += blockDim.x) {
+    int id = neg_indices[i];
+    out_label[bidx * num_prior_box + id] = background_label;
+    out_label_wt[bidx * num_prior_box + id] = 1.;


bidx * num_prior_box has appeared many times and it is inside a loop, so it should be optimized.

… ssd_target_assign

qingqing01

@wanghaox @chengduoZH Thanks for your review.

qingqing01 · 2018-02-07T06:34:44Z

paddle/operators/target_assign_op.cc

@@ -0,0 +1,172 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


qingqing01 · 2018-02-07T06:38:08Z

paddle/operators/target_assign_op.cc

+                      "The rank of Input(NegIndices) must be 2.");
+
+    PADDLE_ENFORCE_EQ(blabel_dims[0], slabel_dims[0],
+                      "The 1st dimension of Input(EncodedGTBBox) and "


qingqing01 · 2018-02-07T06:38:13Z

paddle/operators/target_assign_op.cc

+                      "The 1st dimension of Input(EncodedGTBBox) and "
+                      "Input(GTScoreLabel) must be the same.");
+    PADDLE_ENFORCE_EQ(blabel_dims[1], mi_dims[1],
+                      "The 2nd dimension of Input(EncodedGTBBox) and "


qingqing01 · 2018-02-07T06:39:33Z

paddle/operators/target_assign_op.cc

+             "box in i-th instance.");
+    AddInput("NegIndices",
+             "(LoDTensor, default LoDTensor<int>), The input negative example "
+             "indics with shape [Neg, 1], where is the total number of "


qingqing01 · 2018-02-07T06:39:38Z

paddle/operators/target_assign_op.cc

+             "indics with shape [Neg, 1], where is the total number of "
+             "negative example indices.");
+    AddAttr<int>("background_label",
+                 "(int, default 0), Label id for background class.")


qingqing01 · 2018-02-07T06:52:25Z

paddle/operators/target_assign_op.cc

+                  const size_t* lod, const int num, const int num_prior_box,
+                  const int background_label, int* out_label, T* out_label_wt) {
+    for (int i = 0; i < num; ++i) {
+      for (int j = lod[i]; j < lod[i + 1]; ++j) {


qingqing01 · 2018-02-07T06:52:30Z

paddle/operators/target_assign_op.cu

@@ -0,0 +1,61 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


qingqing01 · 2018-02-07T06:52:37Z

paddle/operators/target_assign_op.h

@@ -0,0 +1,155 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.


qingqing01 · 2018-02-07T07:10:58Z

paddle/operators/target_assign_op.cu

+  for (int i = st + threadIdx.x; i < ed; i += blockDim.x) {
+    int id = neg_indices[i];
+    out_label[bidx * num_prior_box + id] = background_label;
+    out_label_wt[bidx * num_prior_box + id] = 1.;


qingqing01 · 2018-02-07T07:15:55Z

paddle/operators/target_assign_op.h

+    T* obox = out_box_ + (row * num_prior_box_ + col) * 4;
+    int* olabel = out_label_ + row * num_prior_box_ + col;
+    T* obox_wt = out_box_wt_ + row * num_prior_box_ + col;
+    T* olabel_wt = out_label_wt_ + row * num_prior_box_ + col;


Add target_assign_op for SSD detection.

4793e86

qingqing01 changed the title ~~Add target_assign_op for SSD detection.~~ Add target assigner operator for SSD detection. Feb 6, 2018

qingqing01 requested review from wanghaox, pkuyym, wanghaoshuang and chengduoZH February 6, 2018 11:43

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

09b78c7

… ssd_target_assign

wanghaox suggested changes Feb 7, 2018

View reviewed changes

chengduoZH reviewed Feb 7, 2018

View reviewed changes

qingqing01 added 2 commits February 7, 2018 15:55

Update doc and follow comments.

ee7d842

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

53b6ee1

… ssd_target_assign

qingqing01 commented Feb 7, 2018

View reviewed changes

qingqing01 mentioned this pull request Feb 7, 2018

The TODO lists for MobileNet-SSD model. #7488

Closed

25 tasks

wanghaox approved these changes Feb 7, 2018

View reviewed changes

qingqing01 merged commit ae0740c into PaddlePaddle:develop Feb 7, 2018

		@@ -0,0 +1,172 @@
		/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.

		@@ -0,0 +1,155 @@
		/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.

		@@ -0,0 +1,61 @@
		/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.

Add target assigner operator for SSD detection. #8193

Add target assigner operator for SSD detection. #8193

Conversation

qingqing01 commented Feb 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingqing01 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingqing01 commented Feb 6, 2018 •

edited

Loading

qingqing01 left a comment •

edited

Loading