Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve split and concat op #8270

Merged
merged 6 commits into from
Feb 11, 2018

Conversation

Yancey1989
Copy link
Contributor

Related #8119
Fixed #6988

self.outputs = {'Out': [('out%d' % i, out[i]) \
for i in xrange(len(out))]}

def test_check_output(self):
self.check_output()

def test_check_grad(self):
self.check_grad(['X'], ['out0', 'out1', 'out2'])
#def test_check_grad(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment out this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's just used for debugging, remove the comment.

@typhoonzero
Copy link
Contributor

This PR still can not compile.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@Yancey1989 Yancey1989 merged commit 525a4fd into PaddlePaddle:develop Feb 11, 2018
@Yancey1989 Yancey1989 deleted the improve_concat_split_op branch February 11, 2018 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants