Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't save the var which type is RAW #8928

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Don't save the var which type is RAW #8928

merged 1 commit into from
Mar 9, 2018

Conversation

Yancey1989
Copy link
Contributor

Fixed #8691

@Yancey1989 Yancey1989 changed the title Don't save var which type is RAW Don't save the var which type is RAW Mar 9, 2018
typhoonzero
typhoonzero approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yancey1989 Yancey1989 merged commit ccc5418 into PaddlePaddle:develop Mar 9, 2018
@Yancey1989 Yancey1989 deleted the non_save_raw_var branch March 9, 2018 11:28
dzhwinter
dzhwinter reviewed Mar 9, 2018
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be done in save op?

@Yancey1989
Copy link
Contributor Author

FROM @dzhwinter

Should this be done in save op?

Looks like save op only support LodTensor, and I think it is correctly:

Paddle/paddle/fluid/operators/save_op.cc

Lines 90 to 91 in ccc5418

PADDLE_ENFORCE(var->IsType<framework::LoDTensor>(),
"SaveOp only support LoDTensor, %s has wrong type", iname);

As the crash logs in #8691 , it was crashed by Python code: a RAW var may not have shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter left review comments

@typhoonzero typhoonzero typhoonzero approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yancey1989 @dzhwinter @typhoonzero