-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transpiler condition op in optimize #9644
Fix transpiler condition op in optimize #9644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR, only one comment.
persistable=var.persistable, | ||
dtype=var.dtype, | ||
shape=var.shape) | ||
if var.type == core.VarDesc.VarType.STEP_SCOPES: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse framwork.py#Block.clone_variable()
to avoid the similar code?
persistable=var.persistable, | ||
dtype=var.dtype, | ||
shape=var.shape) | ||
print("##### deal var: ", var) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete print
please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again.
Fix transpiler error when running https://github.com/seiriosPlus/fluid_benchmark distributed training using
piecewise_decay
.