Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transpiler condition op in optimize #9644

Merged

Conversation

typhoonzero
Copy link
Contributor

Fix transpiler error when running https://github.com/seiriosPlus/fluid_benchmark distributed training using piecewise_decay.

@typhoonzero typhoonzero requested a review from Yancey1989 April 4, 2018 06:56
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, only one comment.

persistable=var.persistable,
dtype=var.dtype,
shape=var.shape)
if var.type == core.VarDesc.VarType.STEP_SCOPES:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse framwork.py#Block.clone_variable() to avoid the similar code?

persistable=var.persistable,
dtype=var.dtype,
shape=var.shape)
print("##### deal var: ", var)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete print please.

Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again.

@typhoonzero typhoonzero merged commit c00a5de into PaddlePaddle:develop Apr 4, 2018
@typhoonzero typhoonzero deleted the fix_condition_op_in_optimize branch April 4, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants