Unify REGISTER_OP and REGISTER_OPERATOR #9911
Merged
+379
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
previously approved these changes
Apr 14, 2018
tonyyang-svail
force-pushed
the
unify_op_registry
branch
2 times, most recently
from
264652a to
d9a60b4
Compare
added 3 commits
April 17, 2018 00:14
tonyyang-svail
force-pushed
the
unify_op_registry
branch
from
d9a60b4 to
411e888
Compare
tonyyang-svail
changed the title
jacquesqiao
reviewed
Apr 18, 2018
| @@ -558,95 +558,126 @@ Swish Activation Operator. | |||
|
|
|||
| namespace ops = paddle::operators; | |||
|
|
|||
| REGISTER_OP(sigmoid, ops::ActivationOp, ops::SigmoidOpMaker, sigmoid_grad, | |||
| ops::ActivationOpGrad); | |||
| REGISTER_OPERATOR(sigmoid, ops::ActivationOp, ops::SigmoidOpMaker, | |||
There was a problem hiding this comment.
one suggestion, add ; at the end of the register macro.
There was a problem hiding this comment.
I will do it in a separate PR, where I will grep all the op files.
jacquesqiao
approved these changes
Apr 18, 2018
|
Awsome! It is helpful to optimize memory usage and prevent hanging when running |
This was referenced Apr 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7158