Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dist unitest data compare, ensure that dist train have same behavior as local training #9933

Merged
merged 5 commits into from
Apr 17, 2018
Merged

Add dist unitest data compare, ensure that dist train have same behavior as local training #9933

merged 5 commits into from
Apr 17, 2018

Conversation

typhoonzero
Copy link
Contributor

Fix #9874

@jacquesqiao
Copy link
Member

Great Job!

Yancey1989
Yancey1989 previously approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typhoonzero
Copy link
Contributor Author

Seems CI is failing when running test_all_ops

Yancey1989
Yancey1989 approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit 8352f93 into PaddlePaddle:develop Apr 17, 2018
@typhoonzero typhoonzero deleted the add_dist_unit_test branch April 18, 2018 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yancey1989 Yancey1989 Yancey1989 approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@typhoonzero @jacquesqiao @Yancey1989