Skip to content

Conversation

@megemini
Copy link
Contributor

PR Category

User Experience

PR Types

New features

Description

【Hackathon 7th No.12】Adam、AdamW 优化器支持 amsgrad

关联:

npuAdamKernel AdamwKernel 中添加 amsgrad 参数,但不实现相应逻辑 ~

@HydrogenSulfate @luotao1

@paddle-bot
Copy link

paddle-bot bot commented Nov 27, 2024

Thanks for your contribution!

@HydrogenSulfate
Copy link
Collaborator

@megemini 好像还有点问题,
image

@megemini
Copy link
Contributor Author

@megemini 好像还有点问题

no_check_set_white_list 加上去了 ~

The size of inputs_args names (9) must be equal to the size of kernel input_defs (10). 这个问题是不是木有拉取 amsgrad 的那个 pr 代码导致的?

再看一下 CI 吧 ~

@HydrogenSulfate
Copy link
Collaborator

@megemini 好像还有点问题

no_check_set_white_list 加上去了 ~

The size of inputs_args names (9) must be equal to the size of kernel input_defs (10). 这个问题是不是木有拉取 amsgrad 的那个 pr 代码导致的?

再看一下 CI 吧 ~

啊这,是不是死锁了,customdevice依赖主框架,主框架CI依赖customdevice

@megemini
Copy link
Contributor Author

@megemini 好像还有点问题

no_check_set_white_list 加上去了 ~
The size of inputs_args names (9) must be equal to the size of kernel input_defs (10). 这个问题是不是木有拉取 amsgrad 的那个 pr 代码导致的?
再看一下 CI 吧 ~

啊这,是不是死锁了,customdevice依赖主框架,主框架CI依赖customdevice

CI 里木有 no_check_set 的错误了 ~ 只剩下这个参数数量不对的问题了 ~ 🤣

@xiaoguoguo626807 xiaoguoguo626807 merged commit c8372d5 into PaddlePaddle:develop Dec 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants