Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize conv2d kernel signature #151

Merged

Conversation

chenwhql
Copy link
Collaborator

@chenwhql chenwhql commented Oct 13, 2022

Normalize conv2d kernel signature

规范化Conv2D kernel的参数列表,尽可能与python端对齐,移除无用的参数,调整参数顺序等

The Python API signature of conv2d is as follows:

def conv2d(x,
           weight,
           bias=None,
           stride=1,
           padding=0,
           dilation=1,
           groups=1,
           data_format="NCHW",
           name=None):

Copy link
Collaborator

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 603982c into PaddlePaddle:develop Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants