Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data loader int32 overflow #818

Merged
merged 3 commits into from
Oct 9, 2022
Merged

fix data loader int32 overflow #818

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16a3c07
fix data loader int32 overflow
FeixLiu Oct 8, 2022
c7c12aa
int32 for epoch
FeixLiu Oct 8, 2022
6d3c798
Merge branch 'develop' into int64_for_dataloader
haohongxiang Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ppfleetx/data/data_tools/cpp/fast_index_map_helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ void build_blending_indices(
}
}

py::array build_sample_idx(const py::array_t<int32_t> &sizes_,
const py::array_t<int32_t> &doc_idx_,
py::array build_sample_idx(const py::array_t<int64_t> &sizes_,
const py::array_t<int64_t> &doc_idx_,
const int32_t seq_length, const int32_t num_epochs,
const int64_t tokens_per_epoch) {
/* Sample index (sample_idx) is used for gpt2 like dataset for which
Expand All @@ -110,7 +110,7 @@ py::array build_sample_idx(const py::array_t<int32_t> &sizes_,

// Mapping and it's length (1D).
int64_t num_samples = (num_epochs * tokens_per_epoch - 1) / seq_length;
int32_t *sample_idx = new int32_t[2 * (num_samples + 1)];
int64_t *sample_idx = new int64_t[2 * (num_samples + 1)];

cout << " using:" << endl << std::flush;
cout << " number of documents: " << doc_idx_.shape(0) / num_epochs
Expand All @@ -128,15 +128,15 @@ py::array build_sample_idx(const py::array_t<int32_t> &sizes_,
// Index into doc_idx.
int64_t doc_idx_index = 0;
// Begining offset for each document.
int32_t doc_offset = 0;
int64_t doc_offset = 0;
// Start with first document and no offset.
sample_idx[2 * sample_index] = doc_idx_index;
sample_idx[2 * sample_index + 1] = doc_offset;
++sample_index;

while (sample_index <= num_samples) {
// Start with a fresh sequence.
int32_t remaining_seq_length = seq_length + 1;
int64_t remaining_seq_length = seq_length + 1;
while (remaining_seq_length != 0) {
// Get the document length.
auto doc_id = doc_idx[doc_idx_index];
Expand Down Expand Up @@ -164,12 +164,12 @@ py::array build_sample_idx(const py::array_t<int32_t> &sizes_,

// Method to deallocate memory.
py::capsule free_when_done(sample_idx, [](void *mem_) {
int32_t *mem = reinterpret_cast<int32_t *>(mem_);
int64_t *mem = reinterpret_cast<int64_t *>(mem_);
delete[] mem;
});

// Return the numpy array.
const auto byte_size = sizeof(int32_t);
const auto byte_size = sizeof(int64_t);
return py::array(std::vector<int64_t>{num_samples + 1, 2}, // shape
{2 * byte_size, byte_size}, // C-style contiguous strides
sample_idx, // the data pointer
Expand Down