Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distributed] Add dp_gradient_sync_after_accumulate #8045

Merged

Conversation

AndSonder
Copy link
Contributor

@AndSonder AndSonder commented Mar 2, 2024

PR types

Others

PR changes

Others

Description

添加 dp_gradient_sync_after_accumulate 参数

相关PR:

Copy link

paddle-bot bot commented Mar 2, 2024

Thanks for your contribution!

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.51%. Comparing base (e3cb5d2) to head (1168be9).
Report is 10 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/training_args.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8045      +/-   ##
===========================================
- Coverage    56.54%   56.51%   -0.04%     
===========================================
  Files          592      592              
  Lines        91067    91128      +61     
===========================================
+ Hits         51493    51497       +4     
- Misses       39574    39631      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 67964cf into PaddlePaddle:develop Mar 8, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants