Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async hang #9276

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Fix async hang #9276

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b62766
update async save signal
DesmonDay Oct 15, 2024
992063c
fix async save hang
DesmonDay Oct 15, 2024
d3cbb11
fix mtime
DesmonDay Oct 16, 2024
6ee87d9
Merge branch 'develop' of https://github.com/PaddlePaddle/PaddleNLP i…
DesmonDay Oct 16, 2024
3864463
fix auto trainer
DesmonDay Oct 16, 2024
e297405
bug fix
DesmonDay Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paddlenlp/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2509,7 +2509,7 @@
need_to_rotate_checkpoints = need_to_rotate_checkpoints and self.args.local_rank == 0
if need_to_rotate_checkpoints:
self._rotate_checkpoints(use_mtime=True, output_dir=run_dir)
self._rotate_checkpoints(use_mtime=False, output_dir=run_signal_dir)
self._rotate_checkpoints(use_mtime=True, output_dir=run_signal_dir)

Check warning on line 2512 in paddlenlp/trainer/trainer.py

View check run for this annotation

Codecov / codecov/patch

paddlenlp/trainer/trainer.py#L2512 

Added line #L2512 was not covered by tests

if strtobool(os.getenv("FLAG_LLM_PDC", "False")) and not ("async_save" in self.args.unified_checkpoint_config):
# save checkpoint_done file to ensure checkpoint is complete
Expand Down
Loading