Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameter calculation in auto_parallel mode #9327

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

zhiqiu
Copy link
Collaborator

@zhiqiu zhiqiu commented Oct 28, 2024

PR types

Others

PR changes

Others

Description

fix parameter calculation in auto_parallel mode, use local_shape when parameter is dist

Copy link

paddle-bot bot commented Oct 28, 2024

Thanks for your contribution!

@zhiqiu zhiqiu force-pushed the dev/fix_num_params branch from 519bfb5 to 04cdbcc Compare October 28, 2024 10:00
@zhiqiu zhiqiu force-pushed the dev/fix_num_params branch from 04cdbcc to dce969f Compare October 28, 2024 10:02
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.90%. Comparing base (05ae377) to head (dce969f).
Report is 256 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9327      +/-   ##
===========================================
+ Coverage    52.74%   52.90%   +0.16%     
===========================================
  Files          669      669              
  Lines       107240   107862     +622     
===========================================
+ Hits         56559    57068     +509     
- Misses       50681    50794     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit ec39737 into PaddlePaddle:develop Oct 29, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants