Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distributed Dataloader] change process new_group creation #9438

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

由于多次创建dataloader时会出现多次创建通信组,造成显存泄露,因此修改到只统一调用一个global通信组。

Copy link

paddle-bot bot commented Nov 15, 2024

Thanks for your contribution!

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.93%. Comparing base (81a2d43) to head (8a1ef2b).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/data/dist_dataloader.py 9.09% 10 Missing ⚠️
paddlenlp/trainer/trainer.py 33.33% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9438      +/-   ##
===========================================
- Coverage    52.96%   52.93%   -0.04%     
===========================================
  Files          681      676       -5     
  Lines       108066   107920     -146     
===========================================
- Hits         57238    57126     -112     
+ Misses       50828    50794      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI merged commit 2ecf7ef into PaddlePaddle:develop Nov 18, 2024
8 of 12 checks passed
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request Nov 19, 2024
DesmonDay added a commit that referenced this pull request Nov 19, 2024
* [DistDataloader] fix eval new_group (#9438)

* Update dist_dataloader.py (#9451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants