Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llm]fix pp no drop last #9439

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[llm]fix pp no drop last #9439

merged 1 commit into from
Nov 19, 2024

Conversation

lugimzzz
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Description

eval 时修改pp batch_size 和 acc_step

Copy link

paddle-bot bot commented Nov 15, 2024

Thanks for your contribution!

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.84%. Comparing base (b5e3f0c) to head (aba0d89).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9439      +/-   ##
===========================================
- Coverage    53.01%   52.84%   -0.17%     
===========================================
  Files          678      676       -2     
  Lines       108787   108315     -472     
===========================================
- Hits         57668    57241     -427     
+ Misses       51119    51074      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit f21329c into PaddlePaddle:develop Nov 19, 2024
8 of 12 checks passed
@lugimzzz lugimzzz deleted the pp branch December 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants